Skip to content

Handle missing footer menu better - #4684

Merged
marcoacierno merged 1 commit into
mainfrom
handle-missing-menu
Jun 20, 2026
Merged

Handle missing footer menu better#4684
marcoacierno merged 1 commit into
mainfrom
handle-missing-menu

Conversation

@marcoacierno

Copy link
Copy Markdown
Member

What

ToDo

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Jun 20, 2026 7:39pm

@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Fixes a null-crash in the footer when the backend returns null for a missing menu (the API returns null when no menu with that identifier is configured for a conference).

No frontend tests for the null-menu case. The bug this PR fixes had no test, and the fix also has no test. If footerEn or footerIt is null (a real scenario confirmed by the backend test at backend/api/tests/schema/conference/test_menu.py), there's nothing preventing a regression. A snapshot or render test that passes null menus would catch this.

Same class of bug exists in the header. frontend/src/components/header/index.tsx destructures data || { conference: {} } — if data is defined but data.conference is null, that destructure throws. The individual ?? [] guards on links access don't protect against this. Worth fixing in a follow-up.

@marcoacierno
marcoacierno merged commit 9efec6d into main Jun 20, 2026
7 checks passed
@marcoacierno
marcoacierno deleted the handle-missing-menu branch June 20, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant